[Python-3000] help() broken in the py3k-struni branch

[Guido van Rossum]

Thanks for finding the issue!

On this one I think subprocess.py should be changed to allow None
(like all the other open() functions).

I'll check it in.

--Guido

On 6/7/07, Alexandre Vassalotti <alexandre at peadrop.com> wrote:
> On 6/5/07, Guido van Rossum <guido at python.org> wrote:
> > Feel free to mail me a patch to fix it.
> >
>
> Since you asked so politely, here a patch for you. :)
>
> > On 6/5/07, Alexandre Vassalotti <alexandre at peadrop.com> wrote:
> > > Hi,
> > >
> > > I found another bug to report. It seems there is a bug in
> > > subprocess.py that makes help() fail.
> > >
> > > -- Alexandre
> > >
> > > Python 3.0x (py3k-struni, Jun  5 2007, 18:41:44)
> > > [GCC 4.1.2 (Ubuntu 4.1.2-0ubuntu4)] on linux2
> > > Type "help", "copyright", "credits" or "license" for more information.
> > > >>> help(open)
> > > Traceback (most recent call last):
> > >   File "<stdin>", line 1, in <module>
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/site.py", line 350,
> > > in __call__
> > >     return pydoc.help(*args, **kwds)
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/pydoc.py", line
> > > 1687, in __call__
> > >     self.help(request)
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/pydoc.py", line 1731, in help
> > >     else: doc(request, 'Help on %s:')
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/pydoc.py", line 1514, in doc
> > >     pager(render_doc(thing, title, forceload))
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/pydoc.py", line 1313, in pager
> > >     pager(text)
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/pydoc.py", line
> > > 1333, in <lambda>
> > >     return lambda text: pipepager(text, 'less')
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/pydoc.py", line
> > > 1352, in pipepager
> > >     pipe = os.popen(cmd, 'w')
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/os.py", line 717, in popen
> > >     bufsize=buffering)
> > >   File "/home/alex/src/python.org/py3k-struni/Lib/subprocess.py", line
> > > 476, in __init__
> > >     raise TypeError("bufsize must be an integer")
> > > TypeError: bufsize must be an integer
> > > _______________________________________________
> > > Python-3000 mailing list
> > > Python-3000 at python.org
> > > http://mail.python.org/mailman/listinfo/python-3000
> > > Unsubscribe: http://mail.python.org/mailman/options/python-3000/guido%40python.org
> > >
> >
> >
> > --
> > --Guido van Rossum (home page: http://www.python.org/~guido/)
> >
>
>
> --
> Alexandre Vassalotti
>
>


-- 
--Guido van Rossum (home page: http://www.python.org/~guido/)