[Python-bugs-list] [ python-Bugs-491415 ] PyDict_UpdateFromSeq2() unused

[noreply@sourceforge.net]

Bugs item #491415, was opened at 2001-12-10 19:16
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=105470&aid=491415&group_id=5470

Category: Python Interpreter Core
Group: Python 2.2
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Tim Peters (tim_one)
Summary: PyDict_UpdateFromSeq2() unused

Initial Comment:
static int PyDict_UpdateFromSeq2() in
Objects/dictobject.c is not used.  
Should it be used or removed?

----------------------------------------------------------------------

>Comment By: Tim Peters (tim_one)
Date: 2001-12-11 10:52

Message:
Logged In: YES 
user_id=31435

Closed by

Doc/api/concrete.tex; new revision: 1.5
Include/dictobject.h; new revision: 2.23
Misc/NEWS; new revision: 1.332
Objects/dictobject.c; new revision: 2.119

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-11 08:42

Message:
Logged In: YES 
user_id=6380

OK, let's make PyDict_MergeFromSeq2 public, and nuke
PyDict_UpdateFromSeq2. (If I had to do it over again, I
wouldn't make PyDict_Update public, but only PyDict_Merge --
but that's too late.)

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-10 20:10

Message:
Logged In: YES 
user_id=6380

let's talk tomorrow.

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2001-12-10 19:55

Message:
Logged In: YES 
user_id=31435

PyDict_{Update,Merge}FromSeq2 are parallel to PyDict_
{Update,Merge}, taking a sequence of 2-sequences instead of 
a dict.  The former are both static, and unadvertised in 
the header file, just because it wasn't clear to me at the 
time whether we wanted to bloat the public API with them, 
and I wanted to move on to the next bug.  If you care to 
pronounce that they're not public API material, happy to 
rename merge2 and nuke update2 (or, if they are, to make 
them extern and advertise them).

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-10 19:26

Message:
Logged In: YES 
user_id=6380

Tim? It's static but the name looks public???

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=105470&aid=491415&group_id=5470