[Python-bugs-list] [ python-Bugs-409773 ] Bug Fix In dircmp class

noreply@sourceforge.net noreply@sourceforge.net
Mon, 19 Mar 2001 09:08:12 -0800


Bugs item #409773, was updated on 2001-03-19 09:08
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=105470&aid=409773&group_id=5470

Category: Python Library
Group: None
Status: Open
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug Fix In dircmp class

Initial Comment:
Hello, I tried to diff two directories, using
filecmp.dircmp class.

I have Python2.0 installed from source in Debian
(Potato).

The code is the following:
#!/tmp/bin/python
import filecmp
from filecmp import dircmp
a = dircmp('lala','loulou')

b = a.report_full_closure()

print b

It yields:

	hargikas@simula:~/src/mydiff$ ./mydiff.py
	diff lala loulou
	Only in loulou : ['kiko']	
	Traceback (most recent call last):
	  File "./mydiff.py", line 6, in ?
	    b = a.report_full_closure()
	  File "/tmp/lib/python2.0/filecmp.py", line 264,
in 			report_full_closure
	    self.report()
	  File "/tmp/lib/python2.0/filecmp.py", line 241, in
report
	    if self.same_files:
	  File "/tmp/lib/python2.0/filecmp.py", line 147, in
__getattr__
	    self.phase3()
	  File "/tmp/lib/python2.0/filecmp.py", line 214, in
phase3
	    xx = cmpfiles(self.left, self.right,
self.common_files)
	  File "/tmp/lib/python2.0/filecmp.py", line 288, in
cmpfiles
	    res[_cmp(ax, bx, shallow,
use_statcache)].append(x)
	TypeError: too many arguments; expected 2, got 4

Actually the 288 line of filecmp.py is:
	res[_cmp(ax, bx, shallow, use_statcache)].append(x)
and it should be:
	res[cmp(ax, bx, shallow, use_statcache)].append(x)

NOTE the missing undescore, in the correct version.

With that changed it worked ok:
	hargikas@simula:~/src/mydiff$ ./mydiff.py
	diff lala loulou
	Only in loulou : ['kiko']
	Identical files : ['loulou']
	Differing files : ['lala']
	None

Any Ideas???

Best Regards,
Charalampos Gikas,
Virtual Trip LTD
http://www.vtrip-ltd.com

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=105470&aid=409773&group_id=5470