[Python-bugs-list] [ python-Bugs-471720 ] ThreadingMixIn/TCPServer forgets close

[noreply@sourceforge.net]

Bugs item #471720, was opened at 2001-10-16 07:04
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=105470&aid=471720&group_id=5470

Category: Documentation
Group: Python 2.2
Status: Open
Resolution: None
Priority: 5
Submitted By: Max Neunhöffer (neunhoef)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: ThreadingMixIn/TCPServer forgets close

Initial Comment:
When using the SocketServer.TCPServer class in connection with the SocketServer.ThreadingMixIn class
every request produces an open socket, because
the overloaded process_request method only calls
the finish_request method without calling close_request afterwards.

The test in test_socketserver.py does not notice
this.

This is true for Python 2.1.1 and Python 2.2a4.

Documentation for ThreadingMixIn (and ForkingMixIn)
is a little meager.


----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2001-10-16 08:35

Message:
Logged In: YES 
user_id=6380

Can you suggest a fix then?

----------------------------------------------------------------------

Comment By: Max Neunhöffer (neunhoef)
Date: 2001-10-16 07:49

Message:
Logged In: YES 
user_id=350896

I would not like this, because then the correct code for
a handler of a ThreadingMixIn/TCPServer would be different from a standard TCPServer.
It is also not very intuitive from a programmers point of view, who only wants to use the server library.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-10-16 07:31

Message:
Logged In: YES 
user_id=6380

Let's make this a documentation issue. When using threading,
the thread is responsible for closing the socket.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=105470&aid=471720&group_id=5470