[Python-bugs-list] [ python-Bugs-558153 ] Compile error _sre.c on Cray T3E

[noreply@sourceforge.net]

Bugs item #558153, was opened at 2002-05-20 03:12
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=558153&group_id=5470

Category: Build
Group: Platform-specific
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Mark Hadfield (hadfield)
>Assigned to: Michael Hudson (mwh)
Summary: Compile error _sre.c on Cray T3E

Initial Comment:
Building version 2.2.1 on a Cray T3E, compilation fails
on  _sre.c because it the name of a function (join)
clashes with a declaration in a system header
(unistd.h). Operating system is UNICOS/mk--sorry I
can't find out OS version number right now.

Solution is to rename the join function in _sre.c.
Patch is attached.

See thread entitled "Building Python on Cray T3E", 9-18
May 2002, on comp.lang.python.

----------------------------------------------------------------------

>Comment By: Michael Hudson (mwh)
Date: 2002-07-31 09:54

Message:
Logged In: YES 
user_id=6656

Umm, don't know why this sat around for so long.

Checked in as revision 2.83 of Modules/_sre.c.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2002-06-05 19:12

Message:
Logged In: YES 
user_id=6380

MWH: just check it in, if the tests pass.

----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2002-05-29 10:27

Message:
Logged In: YES 
user_id=6656

/F: Any objections?

----------------------------------------------------------------------

Comment By: Mark Hadfield (hadfield)
Date: 2002-05-20 03:17

Message:
Logged In: YES 
user_id=227147

Attempts to attach patch failed. Here it is:

*** /home/skip/tmp/_sre.c.~2.79~        Thu May  9 23:50:23 2002
--- /home/skip/tmp/_sre.c       Thu May  9 23:50:23 2002
***************
*** 1788,1794 ****
  #endif
  
  static PyObject*
! join(PyObject* list, PyObject* pattern)
  {
      /* join list elements */
  
--- 1788,1794 ----
  #endif
  
  static PyObject*
! join_list(PyObject* list, PyObject* pattern)
  {
      /* join list elements */
  
***************
*** 2241,2247 ****
      Py_DECREF(filter);
  
      /* convert list to single string (also removes list) */
!     item = join(list, self->pattern);
  
      if (!item)
          return NULL;
--- 2241,2247 ----
      Py_DECREF(filter);
  
      /* convert list to single string (also removes list) */
!     item = join_list(list, self->pattern);
  
      if (!item)
          return NULL;



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=558153&group_id=5470