[Python-bugs-list] [ python-Bugs-680494 ] filecmp.py uses obsolete statcache module.

SourceForge.net noreply@sourceforge.net
Thu, 06 Feb 2003 08:02:55 -0800


Bugs item #680494, was opened at 2003-02-04 16:55
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=680494&group_id=5470

Category: Python Library
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: Inyeol Lee (inyeol)
Assigned to: Raymond Hettinger (rhettinger)
Summary: filecmp.py uses obsolete statcache module.

Initial Comment:
2.3a1 filecmp module, which is not obsolete, uses
obsolete
statcache module and generates DeprecationWarning.

Inyeol Lee

----------------------------------------------------------------------

>Comment By: Raymond Hettinger (rhettinger)
Date: 2003-02-06 11:02

Message:
Logged In: YES 
user_id=80475

Yes, the test suite looks fine.

The lines for suite.addTest are usually put in a loop.

Instead of the setup/teardown steps, consider adding 
some small static files to the test directory: 
filecmp_basecase, filecmp_samecase, filecmp_diffcase.
That would simplify your code and bypass issues of write 
permissions, running tests from a CD-rom, etc.

----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2003-02-05 14:50

Message:
Logged In: YES 
user_id=11375

Attaching test_filecmp.py.  Raymond, you've written test suites with unittest.py, right?  Am I using it in a reasonable way?


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2003-02-05 14:37

Message:
Logged In: YES 
user_id=11375

Attaching test_filecmp.py.  Raymond, you've written test suites with unittest.py, right?  Am I using it in a reasonable way?


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2003-02-05 14:07

Message:
Logged In: YES 
user_id=11375

There's no test suite for filecmp, so before making any changes, I'm 
going to write a test suite.


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2003-02-05 13:23

Message:
Logged In: YES 
user_id=11375

The simplest thing would be to simply use os.stat instead of statcache,
and deprecate use_statcache by logging a warning if use_statcache is true.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=680494&group_id=5470