[Python-bugs-list] [ python-Bugs-724767 ] Minor /Tools/Scripts/crlf.py bugs

[SourceForge.net]

Bugs item #724767, was opened at 2003-04-20 18:09
Message generated for change (Settings changed) made by akuchling
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=724767&group_id=5470

Category: Demos and Tools
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Submitted By: logistix (logistix)
Assigned to: A.M. Kuchling (akuchling)
Summary: Minor /Tools/Scripts/crlf.py bugs

Initial Comment:
Caught these when I tried to cut-and-paste the code.

crlf.py uses the variable name file, which it shouldn't 
anymore.  I've attached a patch to fix this problem.

It also looks like the method of determining if a file is 
text or binary isn't unicode safe.  Am I right?

----------------------------------------------------------------------

>Comment By: A.M. Kuchling (akuchling)
Date: 2003-05-13 14:16

Message:
Logged In: YES 
user_id=11375

Fixed; thanks!  I'll go grepping for more cases.

----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2003-05-13 13:13

Message:
Logged In: YES 
user_id=11375

Fixed; thanks!  I'll go grepping for more cases.

----------------------------------------------------------------------

Comment By: logistix (logistix)
Date: 2003-05-13 11:07

Message:
Logged In: YES 
user_id=699438

I realized a few days ago that lfcr.py has the same problem.  I 
doubt you need it, but I can submit another patch if 
necessary.

----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2003-05-13 10:53

Message:
Logged In: YES 
user_id=11375

Fixed (though I changed the variable name to 'filename', not 'file_'.)

Yes, it won't be Unicode-safe if the file is in a 16-bit encoding 
such as UCS-2.  It'll be fine for other encodings; for example, UTF-8
wouldn't be a problem.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=724767&group_id=5470