[Python-bugs-list] [ python-Bugs-827856 ] object.h misdocuments PyDict_SetItemString

SourceForge.net noreply at sourceforge.net
Sun Nov 2 12:11:18 EST 2003


Bugs item #827856, was opened at 2003-10-22 00:47
Message generated for change (Comment added) made by aleax
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=827856&group_id=5470

>Category: Python Interpreter Core
Group: Python 2.3
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Greg Chapman (glchapman)
>Assigned to: Alex Martelli (aleax)
Summary: object.h misdocuments PyDict_SetItemString

Initial Comment:
I just happened to notice the following in the comment 
titled "Reference Counts" toward the end of object.h 
(2.3.2):

Functions that 'store' objects such as PyTuple_SetItem
() and PyDict_SetItemString()
don't increment the reference count of the object

I believe PyDict_SetItemString does increment the 
refcount.


----------------------------------------------------------------------

>Comment By: Alex Martelli (aleax)
Date: 2003-11-02 18:11

Message:
Logged In: YES 
user_id=60314

I have fixed (and otherwise clarified) the comment in question, as per
glchapman's patch, and committed the change to the 2.3 maintenance branch of CVS .


----------------------------------------------------------------------

Comment By: Greg Chapman (glchapman)
Date: 2003-11-02 15:42

Message:
Logged In: YES 
user_id=86307

Attached is a patch (against 2.3.2 object.h) which changes 
the reference to PyDict_SetItemString to PyList_SetItem.  It 
also corrects another typo I noticed this morning.

----------------------------------------------------------------------

Comment By: Johan M. Hahn (johahn)
Date: 2003-10-25 11:29

Message:
Logged In: YES 
user_id=887415

Hi Greg, you are right, whoever wrote it probably meant 
PyList_SetItem (according to Ref.Manual 1.2.1.1 and source). 
Will you submit a patch?
...johahn

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=827856&group_id=5470



More information about the Python-bugs-list mailing list