[ python-Bugs-1083645 ] Tests fail instead of skip

[SourceForge.net]

Bugs item #1083645, was opened at 2004-12-11 15:06
Message generated for change (Comment added) made by bcannon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1083645&group_id=5470

Category: Build
Group: Python 2.4
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Detlef Vollmann (dvch)
Assigned to: Nobody/Anonymous (nobody)
Summary: Tests fail instead of skip

Initial Comment:
On Linux, with threads disabled (--with-threads=no),
the tests test_imp, test_list and test_userlist
fail instead of skipping.

----------------------------------------------------------------------

>Comment By: Brett Cannon (bcannon)
Date: 2004-12-18 13:10

Message:
Logged In: YES 
user_id=357491

test_imp is now skipped on platforms that don't have 
threading.  Covered by rev. 1.5 in HEAD, rev. 1.4.14.1 for 2.4, and rev. 
1.4.10.1 for 2.3 .

This takes care of all the reported tests.

----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2004-12-18 11:41

Message:
Logged In: YES 
user_id=80475

Applied the decimal fixup.  It is no longer dependent on
threads.

See Lib/decimal.py 1.32 and 1.31.2.1

Am unassigning myself for the rest.  It's not an especially
high priority to teach regrtest.py about tests that should
be skipped when there are no threads.

----------------------------------------------------------------------

Comment By: Detlef Vollmann (dvch)
Date: 2004-12-18 08:04

Message:
Logged In: YES 
user_id=729909

test_list and test_userlist succeed now, great, thanks.
test_imp still fails as before :-(

Detlef

----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2004-12-18 06:34

Message:
Logged In: YES 
user_id=80475

Please try out the attached patch and let me know if the
full test_suite passes.

----------------------------------------------------------------------

Comment By: Detlef Vollmann (dvch)
Date: 2004-12-18 03:48

Message:
Logged In: YES 
user_id=729909

Sorry, from the short output of 'make test' the problem
seemed obvious:
test_imp
test test_imp failed -- expected imp.lock_held() to be True
...
test_list
ImportError: No module named thread
...
test_userlist
ImportError: No module named thread

But after running the tests manually, I noticed that the latter
two tests are complete test packs.
The complete output is attached.

Detlef

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2004-12-17 20:33

Message:
Logged In: YES 
user_id=357491

Can you run these tests individually and save the output to see how they 
are failing?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1083645&group_id=5470