[ python-Bugs-885293 ] Two lines in object.c seem useless.

SourceForge.net noreply at sourceforge.net
Tue Jan 27 15:19:54 EST 2004


Bugs item #885293, was opened at 2004-01-26 22:22
Message generated for change (Comment added) made by bcannon
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=885293&group_id=5470

Category: Python Interpreter Core
Group: Not a Bug
Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Josiah Carlson (josiahcarlson)
Assigned to: Brett Cannon (bcannon)
Summary: Two lines in object.c seem useless.

Initial Comment:
The lines numbered 749 and 758 that read:
	PyTypeObject *vtp;
and
	vtp = v->ob_type;
respectively, seem to have no use in implementation of
PyObject_Compare in the current CVS.

One would hope that a sane compiler would optimize
those lines out, but one cannot be certain.

----------------------------------------------------------------------

>Comment By: Brett Cannon (bcannon)
Date: 2004-01-27 12:19

Message:
Logged In: YES 
user_id=357491

OK, compiled with no problem so the line removals have been 
checked in.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2004-01-27 12:19

Message:
Logged In: YES 
user_id=357491

OK, compiled with no problem so the line removals have been 
checked in.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2004-01-27 00:17

Message:
Logged In: YES 
user_id=357491

Looks like you are right, Josiah.  I am compiling now and will run 
the test suite quickly to make sure our eyes aren't lying to us.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=885293&group_id=5470



More information about the Python-bugs-list mailing list