[ python-Bugs-978662 ] can't compile _localemodule.c w/o --enable-toolbox-glue

[SourceForge.net]

Bugs item #978662, was opened at 2004-06-24 03:56
Message generated for change (Comment added) made by jackjansen
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=978662&group_id=5470

Category: Macintosh
Group: Python 2.4
Status: Open
Resolution: None
Priority: 5
Submitted By: Brett Cannon (bcannon)
Assigned to: Jack Jansen (jackjansen)
Summary: can't compile _localemodule.c w/o --enable-toolbox-glue

Initial Comment:
Line 412 of Modules/_localemodule.c calls PyMac_getscript() which 
is within a ``#if defined(__APPLE__)`` block.  Trouble is that the 
code is in Python/mactoolboxglue.c which is not compiled if --
disable-toolbox-glue is a compile option (which it was on my OS X 
10.3.4 box).  Probably shouldn't have a compile failure thanks to ld 
not finding the symbol; should probably either just not compile the 
module, change the #if block, or change the function.

----------------------------------------------------------------------

>Comment By: Jack Jansen (jackjansen)
Date: 2004-06-25 13:56

Message:
Logged In: YES 
user_id=45365

There are two solutions:
1) Move PyMac_getscript() to _localemodule.
2) Copy PyMac_getscript() to _localemodule.
3) #ifdef PyLocale_getdefaultlocale in _localemodule on something set by 
enable_toolbox_module_glue.

1) means we can't really put the external declaration in macglue.h any 
more (_localemodule needn't be configured), but I don't think it's used by 
anything but localemodule, so it's probably the best solution.

Still, this is an incompatible change, so we shouldn't backport it.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=978662&group_id=5470