[ python-Bugs-1231069 ] ioctl has problem with -ive request codes

[SourceForge.net]

Bugs item #1231069, was opened at 2005-07-01 17:24
Message generated for change (Settings changed) made by mwh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1231069&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Barry Alan Scott (barry-scott)
Assigned to: Michael Hudson (mwh)
Summary: ioctl has problem with -ive request codes

Initial Comment:
On Linux many ioctl request code values cannot be
passed to ioctl
because it assumes that the values are signed ints.
Value with the
top bit set 0x8000000 are common.

Changing the PyArg_ParseTuple calls to use "I" instead
of "i"
fixes the problem.

This may well also be the issue with bug 1112949
"ioctl has problems on 64 bit machines".

The attached patch fixes the problem in 2.4.1 and was
tested on FC4.


----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2005-07-27 21:25

Message:
Logged In: YES 
user_id=6656

Finally committed this as:

Modules/fcntlmodule.c revision 2.44
Misc/NEWS revision 1.1326

Thanks, and sorry for the delay...

----------------------------------------------------------------------

Comment By: Barry Alan Scott (barry-scott)
Date: 2005-07-18 11:57

Message:
Logged In: YES 
user_id=28665

I've messed up attchments on SF before but
the patch downloads for me.

Barry


----------------------------------------------------------------------

Comment By: Michael Hudson (mwh)
Date: 2005-07-03 15:50

Message:
Logged In: YES 
user_id=6656

The patch seems to be empty (!?)

Good idea, although not goo enough for me to fight CVS over dialup...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1231069&group_id=5470