[ python-Bugs-1195576 ] [AST] Patch [ 1190012 ] should've checked for SyntaxWarnings

[SourceForge.net]

Bugs item #1195576, was opened at 2005-05-04 23:13
Message generated for change (Comment added) made by nascheme
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1195576&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Parser/Compiler
Group: AST
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: logistix (logistix)
Assigned to: Brett Cannon (bcannon)
Summary: [AST] Patch [ 1190012 ] should've checked for SyntaxWarnings

Initial Comment:
"[ 1190012 ] don't assume all errors are syntax errors"
should also check allow SyntaxWarnings to pass.  This
is a one-line fix at around line 104 in
ast_error_finish in ast.c.

This causes the failure in test_warnings.py.

Brett,

If you really want a patch, I can get you one, but
right now my copy of ast.c is a little too far out of
sync to generate a clean patch.  The fix is pretty
trivial though.

Let me know.

-Grant



----------------------------------------------------------------------

>Comment By: Neil Schemenauer (nascheme)
Date: 2005-10-12 00:55

Message:
Logged In: YES 
user_id=35752

SyntaxWarnings are now generated by the AST compiler and
test_warnings.py passes.

----------------------------------------------------------------------

Comment By: Neil Schemenauer (nascheme)
Date: 2005-06-18 18:05

Message:
Logged In: YES 
user_id=35752

I haven't dug to deep into this but test_warnings now
passes.  The ast.c ast_error_finish function doesn't seem to
have been changed.  I think test_warnings was failing for
some other reason.

It looks like SyntaxWarnings are not currently generated by
newcompile.c.  I'm leaving this issue open until that gets
fixed.  Probably a test should be added that actually causes
a SyntaxWarning to be generated by the compiler.

----------------------------------------------------------------------

Comment By: Brett Cannon (bcannon)
Date: 2005-05-06 20:01

Message:
Logged In: YES 
user_id=357491

I shouldn't need a patch, but it might be a little while
until I get to this.  I am down to the last couple of weeks
of the quarter and I am racing to get my masters thesis done
before I graduate.  Plus a quick recompile the other night
under gcc 4 led to a ton of errors for me (hoping it was
just a fluke; something about sem_init() ).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1195576&group_id=5470