[ python-Bugs-1472710 ] Bug in threadmodule.c:local_traverse

[SourceForge.net]

Bugs item #1472710, was opened at 2006-04-18 22:34
Message generated for change (Comment added) made by collinwinter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1472710&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Extension Modules
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: Collin Winter (collinwinter)
Assigned to: Nobody/Anonymous (nobody)
Summary: Bug in threadmodule.c:local_traverse

Initial Comment:
threadmodule.c's local_traverse function does not call
Py_VISIT on self->key. Attached is a one-line patch
against r45556 to add the call.

----------------------------------------------------------------------

>Comment By: Collin Winter (collinwinter)
Date: 2006-04-19 10:44

Message:
Logged In: YES 
user_id=1344176

Aha. In which case, I'll work up a patch for the docs
instead. Thanks for the clairification. I'll go ahead and
close this report.

----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2006-04-19 00:42

Message:
Logged In: YES 
user_id=31435

It doesn't really matter:  self->key is either NULL or a
Python string object, and neither can be involved in a
cycle, so for purposes of cyclic gc it's just a waste of
time to pass the key to a visit() callback.   The docs could
be clearer about this.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1472710&group_id=5470