[ python-Bugs-1540386 ] SocketServer.ForkingMixIn.collect_children() waits on pid 0

[SourceForge.net]

Bugs item #1540386, was opened at 2006-08-14 21:48
Message generated for change (Comment added) made by nnorwitz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1540386&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Nobody/Anonymous (nobody)
Summary: SocketServer.ForkingMixIn.collect_children() waits on pid 0

Initial Comment:
SocketServer.ForkingMixIn.collect_children() does:

       pid, status = os.waitpid(0, options)

By setting pid = 0, it will wait on any children, even
if the children were not started by the SocketServer. 
This causes sporadic test failures:

 
http://mail.python.org/pipermail/python-dev/2006-August/068216.html

It later assumes that if any child finished, that this
server owned the process, which is not a valid
assumption.  Any part of the code could have spawned
the child.

I will fix the test suite, so this problem shouldn't
occur (well at least reduce the likelihood by reaping
the children before each test).

I'm not certain how this problem should really be fixed
(or if it's even worth fixing).  Two possible solutions
are: 
 * only wait on the children we own
 * ignore returned pids that we don't own


----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2006-08-14 21:49

Message:
Logged In: YES 
user_id=33168

I forgot to mention that this problem seems to have
sporadically hit many of the buildbots.  Though it seemed to
always occur on cygwin.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1540386&group_id=5470