[ python-Bugs-1603424 ] subprocess.py (py2.5) wrongly claims py2.2 compatibility

[SourceForge.net]

Bugs item #1603424, was opened at 2006-11-26 20:07
Message generated for change (Comment added) made by racarr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1603424&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.5
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tim Wegener (twegener)
Assigned to: Nobody/Anonymous (nobody)
Summary: subprocess.py (py2.5) wrongly claims py2.2 compatibility

Initial Comment:
>From the comments in subprocess.py (py2.5):
# This module should remain compatible with Python 2.2, see PEP 291.

However, using it from Python 2.2 gives:
NameError: global name 'set' is not defined

(set built-in used on line 1005)

The subprocess.py in py2.4 was 2.2 compatible. 

Either the compatibility comment should be removed/amended or compatibility fixed. 


----------------------------------------------------------------------

Comment By: Robert Carr (racarr)
Date: 2006-12-05 10:10

Message:
Logged In: YES 
user_id=1649655
Originator: NO

Index: subprocess.py
===================================================================
--- subprocess.py       (revision 52918)
+++ subprocess.py       (working copy)
@@ -1004,8 +1004,8 @@

                     # Close pipe fds.  Make sure we don't close the same
                     # fd more than once, or standard fds.
-                    for fd in set((p2cread, c2pwrite,
errwrite))-set((0,1,2)):
-                        if fd: os.close(fd)
+                    for fd in (p2cread,c2pwrite,errwrite):
+                        if fd not in (0,1,2): os.close(fd)

                     # Close all other fds, if asked for
                     if close_fds:

Fixed?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1603424&group_id=5470