[ python-Bugs-1545837 ] array.array borks on deepcopy

[SourceForge.net]

Bugs item #1545837, was opened at 2006-08-24 11:49
Message generated for change (Comment added) made by twouters
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1545837&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.5
>Status: Closed
>Resolution: Fixed
Priority: 9
Private: No
Submitted By: Václav Haisman (wilx)
Assigned to: Thomas Wouters (twouters)
Summary: array.array borks on deepcopy

Initial Comment:
Hi,
I think there is a bug arraymodule.c this line:

	{"__deepcopy__",(PyCFunction)array_copy,	METH_NOARGS,
	 copy_doc},

should probably have METH_O instead of METH_NOARGS
there, since according to docs and the prototype of the
array_copy() function there is one parameter.


----------------------------------------------------------------------

>Comment By: Thomas Wouters (twouters)
Date: 2006-12-29 16:05

Message:
Logged In: YES 
user_id=34209
Originator: NO

Backported.

----------------------------------------------------------------------

Comment By: Thomas Wouters (twouters)
Date: 2006-12-28 10:11

Message:
Logged In: YES 
user_id=34209
Originator: NO

The 2.5 branch at the time was still pre-2.5.0, and we didn't want to make
this change between release candidate and release. It's safe to be checked
into release25-maint now. I'll do it sometime tonight.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-12-28 08:59

Message:
Logged In: YES 
user_id=33168
Originator: NO

Thomas, was there any reason this wasn't checked in to 2.5?  I'm guessing
it was just forgotten.  I don't see any mention in Misc/NEWS either.  

----------------------------------------------------------------------

Comment By: Thomas Wouters (twouters)
Date: 2006-08-29 09:35

Message:
Logged In: YES 
user_id=34209

Not unless you want another release candidate. copy.deepcopy
has never worked on array instances, so it's not a
release-preventing bug (but each bugfix may *add* a
release-preventing bug by accident :)


----------------------------------------------------------------------

Comment By: Raymond Hettinger (rhettinger)
Date: 2006-08-28 15:32

Message:
Logged In: YES 
user_id=80475

Should this be fixed in the release candidate?

----------------------------------------------------------------------

Comment By: Thomas Wouters (twouters)
Date: 2006-08-24 20:50

Message:
Logged In: YES 
user_id=34209

Thanks! Fixed in the trunk (which is 2.6-to-be) revision
51565, and it will also be fixed for Python 2.4.4 and 2.5.1.
It's unfortunately just a bit too late for 2.5.0.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1545837&group_id=5470