[ python-Bugs-1500293 ] Memory leak in subprocess module

[SourceForge.net]

Bugs item #1500293, was opened at 2006-06-04 03:30
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1500293&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Extension Modules
Group: Python 2.4
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Žiga Seilnacht (zseil)
Assigned to: Peter Ã
strand (astrand)
Summary: Memory leak in subprocess module

Initial Comment:
The memory leak is in _subprocess module in functions
getint and gethandle. They forget to decref the objects
returned by PyObject_GetAttrString(). The bug is
present in version 2.4 as well as in the trunk.

Few more bugs in the subprocess module that I found
while looking for the leak:

- class STARTUPINFO is missing a wShowWindow attribute
  (this is hidden because _subprocess.CreateProcess()
   ignores most of the exceptions)

- _execute_child() had a nonsensical test
  (if not None in tuple_of_posible_file_handles)

- _execute_child() is assigning attributes to a
  default_startupinfo, which isn't used if user
  supplies another one.

----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-06-04 22:16

Message:
Logged In: YES 
user_id=849994

Thanks! Fixed in rev. 46651, 46652.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1500293&group_id=5470