[ python-Bugs-1570284 ] Launcher reset to factory button provides bad command-line

[SourceForge.net]

Bugs item #1570284, was opened at 2006-10-03 23:17
Message generated for change (Settings changed) made by ronaldoussoren
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1570284&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Macintosh
Group: Python 2.5
>Status: Pending
>Resolution: Fixed
Priority: 5
Submitted By: jjackson (jejackson)
Assigned to: Ronald Oussoren (ronaldoussoren)
Summary: Launcher reset to factory button provides bad command-line

Initial Comment:
If I push the "Reset to factory settings" in Python Launcher's Preferences 
window, the command line gets a bogues "(null)" inserted, which makes a 
mess of things. I don't think that was what was intended.

In trying to debug this, I notice in the source for FileSettings.m, at line 
209
there are two duplicated lines:

            [NSNumber numberWithBool: nosite], @"nosite",
            [NSNumber numberWithBool: nosite], @"nosite",

Also, I notice at FileSettings.m:236

    value = [dict objectForKey: @"nosite"];
    if (value) nosite = [value boolValue];
    value = [dict objectForKey: @"nosite"];
    if (value) tabs = [value boolValue];

I'm wondering if these second "nosite"s should be "tabs", and if that 
would fix the problem.

----------------------------------------------------------------------

Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-10-08 19:44

Message:
Logged In: YES 
user_id=580910

Fixed in revision 52229 (trunk), 52230 (2.5 branch) and 52231/52232 (2.4 
branch).

The latter checkin is a lot larger than just this fix, it is a backport of the entire 
universal binary support code from 2.5 to the official 2.4 tree (the 2.4.3. 
installer was build from an out-of-tree "branch").

----------------------------------------------------------------------

Comment By: Ronald Oussoren (ronaldoussoren)
Date: 2006-10-06 12:26

Message:
Logged In: YES 
user_id=580910

I'll have a look at this this weekend. On first glance the analysis for the source 
code looks correct and both lines should be changed, but I don't have time just 
ow to do this and test the results just now (and then backport to the 2.5 and 2.4 
trees)

P.S. I'll be doing a huge checking on the 2.4 branch this weekend, backporting 
the universal python stuff to the official tree. Last week was busier than 
expected, hence the late checkin.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2006-10-04 07:48

Message:
Logged In: YES 
user_id=33168

Ronald, I'm guessing that Jack still doesn't have time.  Do
you know anything about this?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1570284&group_id=5470