[issue1564] The set implementation should special-case PyUnicode instead of PyString

Raymond Hettinger report at bugs.python.org
Mon Dec 10 16:11:03 CET 2007


Raymond Hettinger added the comment:

I had looked at the version 2 instead of version 3.

Version 3 is much closer.  A couple of comments.  Don't change the 
brace opening/closing convention in the file -- stick with the K&R 
style -- mixing two different styles makes the file harder to read and 
maintain.

Also, do not introduce string optimization in new places.  If it wasn't 
there before, it was likely left out for a reason (lines 1231 and 1352 
for example).

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue1564>
__________________________________


More information about the Python-bugs-list mailing list