[issue1635] Float patch for inf and nan on Windows (and other platforms)

Guido van Rossum report at bugs.python.org
Tue Dec 18 20:48:33 CET 2007


Guido van Rossum added the comment:

Mostly looks good.  Here are some nits.

(1) You shouldn't have to add pystrcmp.c to the VC project files since
on Windows it isn't used, right?

(2) Will the Windows input routine still accept the *old*
representations for INF and NAN?  IMO that's important (a) so as to be
able to read old pickles or marshalled data, (b) so as to be able to
read data files written by C programs.

(3) Shouldn't you be using Py_HUGE_VAL instead of HUGE_VAL in the chunk
starting at line 187 in floatobject.c?

----------
nosy: +gvanrossum

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue1635>
__________________________________


More information about the Python-bugs-list mailing list