[issue2719] Backport next()

Guido van Rossum report at bugs.python.org
Wed Apr 30 18:48:51 CEST 2008


Guido van Rossum <guido at python.org> added the comment:

+1 on this. I have a few nits about the code:

Line 1083: "%.200s object is not an iterator", it->ob_type->tp_name);
Line is too long.

Line 1088: if (res == NULL) {
How about

  if (res != NULL)
    return res;

?

Line 1089: if (def) {
if (def != NULL) {

Line 1093: PyErr_Clear();
I would only call this if PyErr_Occurred() returns true.

----------
resolution:  -> accepted

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue2719>
__________________________________


More information about the Python-bugs-list mailing list