[issue3008] Let bin/oct/hex show floats

Raymond Hettinger report at bugs.python.org
Tue Jul 15 04:28:55 CEST 2008


Raymond Hettinger <rhettinger at users.sourceforge.net> added the comment:

The patch looks good.  I would coded hex_from_char() using a lookup 
into "0123456789abcdef" which uses no unpredicatable branches.  
Likewise, I would done hex_from_char() with a case statement (limiting 
the call to single unpredicatable branch).

Question:  are the ("0x0p+0") and ("-0x0p+0") special cases standard?

The docs need a "new in py2.6"

Coding style:  move the inner si++ to a separate line so there are no 
side-effects and the order of execution is obvious.

Question:  should the "inf" string checks be made case sensitive on 
insensitive?  Is there a standard?

----------
resolution:  -> accepted

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3008>
_______________________________________


More information about the Python-bugs-list mailing list