[issue2298] Patch for "string without null bytes" check in getargs.c

Alexander Belopolsky report at bugs.python.org
Mon Mar 17 16:29:54 CET 2008


Alexander Belopolsky <belopolsky at users.sourceforge.net> added the comment:

On Mon, Mar 17, 2008 at 9:51 AM, Alexandre Vassalotti <
report at bugs.python.org> wrote:

>
> Alexandre Vassalotti <alexandre at peadrop.com> added the comment:
>
> .. Although I haven't reviewed this
> patch yet, I find the naming of the `ustr` variable confusing -- e.g. is
> it a bytes object or a unicode object?

There is no `ustr` variable , you  probably mean  `uarg`.   If so, it  is
not introduced by the patch.   To me the patch looks straightforward and
correct, but a unit test should be added.  Some additional refactoring is
due for getargs.c (does py3k support builds without Py_USING_UNICODE?), but
the bug fix should not wait for that.

Added file: http://bugs.python.org/file9688/unnamed

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue2298>
__________________________________
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: unnamed
Url: http://mail.python.org/pipermail/python-bugs-list/attachments/20080317/c0f906f6/attachment.txt 


More information about the Python-bugs-list mailing list