[issue1503] test_xmlrpc is still flakey

[Ralf Schmitt]

Ralf Schmitt <schmir at gmail.com> added the comment:

With the following diff, test_xmlrpc.py passes without problems.

Like I said, someone else should decide where to turn on blocking mode.
I now think that it should be in the socket.accept (i.e. in the C code)
at least for unix platforms.
Those who really want a nonblocking socket, will most probably call that
setblocking(0) anyway (or their program is broken on linux, which
returns blocking sockets by default).



--- a/Lib/SocketServer.py	Wed Mar 26 22:41:36 2008 +0100
+++ b/Lib/SocketServer.py	Wed Mar 26 23:48:13 2008 +0100
@@ -441,8 +441,10 @@
         May be overridden.
 
         """
-        return self.socket.accept()
-
+        r= self.socket.accept()
+        r[0].setblocking(1)
+        return r
+    
     def close_request(self, request):
         """Called to clean up an individual request."""
         request.close()

__________________________________
Tracker <report at bugs.python.org>
<http://bugs.python.org/issue1503>
__________________________________