[issue1699259] replacing char* with const char* in sysmodule.c/.h

Alexander Belopolsky report at bugs.python.org
Thu Nov 13 05:26:04 CET 2008


Alexander Belopolsky <belopolsky at users.sourceforge.net> added the comment:

The patch no longer applies to trunk, but that would be trivial to fix.

Changes like these have been accepted with little resistance in the past 
(see e.g. issue651362), so I don't see why this patch has been pending 
for  so long.  (In general, I am -0 on adding const modifiers because 
they tend to trigger an avalanche of changes, but arguably this is the 
"right thing to do.")   

A few comments:

* Documentation needs to be updated in Doc/c-api/sys.rst. 

* Any reason why PySys_SetPath(char *) is left out?

* Same for PySys_SetArgv(int, char **)

* Similar changes are proposed in issue1772673.  Maybe these two issues 
can be dealt with together.

----------
nosy: +belopolsky

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue1699259>
_______________________________________


More information about the Python-bugs-list mailing list