[issue2053] IDLE - standardize dialogs

Tal Einat report at bugs.python.org
Sun Aug 2 21:22:19 CEST 2009

Tal Einat <taleinat at users.sourceforge.net> added the comment:

The whole point of this patch is to make the EditorWindow's Text widget
the default master/parent for its dialogs!

IMO this makes sense, since this is a reasonable and intuitive default
for such methods of the EditorWindow object. I understand the "explicit
is better than implicit" argument, but that doesn't mean that having a
reasonable default value is always wrong. In this case having a default
value both simplifies the code considerably and makes sense, so IMO it
is justified.

Also, please note that the patch actually reduces the size of
EditorWindow.py (both character and line counts) and cleans up the code
in many places. Yes, the definition of the relevant methods is not
trivial, but it is in just one area of the code.


Python tracker <report at bugs.python.org>

More information about the Python-bugs-list mailing list