[issue5450] test_tcl testLoadTk fails if DISPLAY defined but connect fails, instead of being skipped

[R. David Murray]

R. David Murray <rdmurray at bitdance.com> added the comment:

I tried using TestSkipped first, but since I was throwing it from an
individual testcase and not from the top level, it still showed up as an
error in test_tcl (I may have done it wrong, of course).

Moving the tests makes more sense anyway, so I've revised my patch to do
that.  I didn't move all of the tests because as far as I could
understand the test.test_tk code, if I moved them all they'd only get
run if the GUI resource was enabled, and that seems wrong.  So I just
moved the tests that specifically involved tk.

I ran the test suite under a variety of DISPLAY settings and
non-settings, and it seemed to do the right thing with the patch
applied.  I have pushed the change up to Launchpad as well.

----------
Added file: http://bugs.python.org/file13308/test_tcl.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5450>
_______________________________________