[issue5006] Duplicate UTF-16 BOM if a file is open in append mode

STINNER Victor report at bugs.python.org
Thu Mar 26 18:26:30 CET 2009


STINNER Victor <victor.stinner at haypocalc.com> added the comment:

> - I'm not sure why you make self->ok handling more complicated than it was

tell() requires self->ok=1. I choosed to reset self->ok to zero on error, but 
it's maybe useless.

> - encodefunc should not be forced to NULL, otherwise it will yield a big
> decrease in write() performance

self>encodefunc value have to be changed because <encoder>.setstate() changes 
the encoding function: UTF-16 => UTF-16-LE or UTF-16-BE.

I don't know how to get the new value of self>encodefunc. I will try to write 
another patch.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5006>
_______________________________________


More information about the Python-bugs-list mailing list