[issue5463] Remove deprecated features from struct module
Mark Dickinson
report at bugs.python.org
Fri Mar 27 14:47:38 CET 2009
Mark Dickinson <dickinsm at gmail.com> added the comment:
Thanks for the patch. A couple of questions and comments:
(1) at line 300-ish of test_struct, should (struct.error, TypeError) be
(struct.error, OverflowError)? I don't think out-of-range values should
be raising TypeError. If they are, perhaps we should change that.
(2) It looks like the deprecated_err function isn't needed any more
(yay!); let's remove it.
(3) I'd prefer to keep the test_1229380 bit, but just replace the
deprecated_err with an assertRaises, just like you already did further
up. As far as I can see those tests aren't entirely duplicated by
others, and one can never have too many tests...
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5463>
_______________________________________
More information about the Python-bugs-list
mailing list