[issue3392] subprocess fails in select when descriptors are large

[Mattias Engdegård <report@bugs.python.org> at psf.upfronthosting.co.za]

Mattias Engdegård <yorick at users.sourceforge.net> added the comment:

The patch looks all right in general. I would use something like

if "poll" in dir(select)

instead of catching AttributeError which risks hiding bugs in 
_communicate_with_poll().

PEP8 probably wants spaces around the bitwise-or operator.

Some systems cannot use TTYs in poll(2) but this should not be a 
problem here - there is no point in using .communicate() with stdin/
stdout/stderr set to anything but PIPE, right?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3392>
_______________________________________