[issue2054] add ftp-tls support to ftplib - RFC 4217

Antoine Pitrou report at bugs.python.org
Thu Oct 15 20:27:38 CEST 2009

Antoine Pitrou <pitrou at free.fr> added the comment:

>From a quick look at the patch, if you call login() twice, the socket
will be wrapped twice as well? Perhaps auth_tls() should have a
protection against this.

In prot_p() and prot_c(), it seems that self._prot_p is updated
unconditionally, regardless of the FTP response.

In retrbinary(), retrlines(), storbinary() and storlines(), you
certainly want some try/finally blocks so that the data connection
always gets closed at the end.


Python tracker <report at bugs.python.org>

More information about the Python-bugs-list mailing list