[issue7467] The zipfile module does not check files' CRCs, including in ZipFile.testzip

Nir Aides report at bugs.python.org
Thu Aug 12 11:15:27 CEST 2010


Nir Aides <nir at winpdb.org> added the comment:

I think patch may be simplified. Instead of keeping track of CRC offset, invoke it directly on the 'data' variable being added to _readbuffer. 

Also the call to _update_crc() before the return from read1() looks redundant.

Finally, is it possible to determine end of file if length of 'data' (computed for crc) is 0?

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue7467>
_______________________________________


More information about the Python-bugs-list mailing list