[issue2142] difflib.unified_diff(...) produces invalid patches

Éric Araujo report at bugs.python.org
Fri Dec 3 03:42:56 CET 2010


Éric Araujo <merwok at netwok.org> added the comment:

To sum up the current consensus as I understand it, the missing end of line is clearly a bug, but the addition of “\No newline at end of file” is controversial.  In the current patch, both are changed, so backporting only the first fix to 3.1 and 2.7 will require either agreeing to add “\No newline etc” in those versions too, or make another patch for 3.1/2.7.

I uploaded the patch to http://codereview.appspot.com/3432041/ and made some minor comments.

----------
nosy: +benjamin.peterson, djc, eric.araujo, georg.brandl -BreamoreBoy

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue2142>
_______________________________________


More information about the Python-bugs-list mailing list