[issue8912] `make patchcheck` should check the whitespace of .c/.h files

Alexander Belopolsky report at bugs.python.org
Mon Jul 5 06:35:00 CEST 2010

Alexander Belopolsky <belopolsky at users.sourceforge.net> added the comment:

Hmm, it looks like patchcheck does not fix trailing whitespace in c files:

$ grep ' $' Modules/datetimemodule.c| cat -ve
                   GET_TD_DAYS(offset1) * 86400 - $
                Py_DECREF(offset);                $
	    if ((offset1 != offset2) && $
$ make patchcheck
Modules/Setup.dist is newer than Modules/Setup;
check to make sure you have all the updates you
need in your Modules/Setup file.
Usually, copying Modules/Setup.dist to Modules/Setup will work.
./python.exe ./Tools/scripts/patchcheck.py
Getting the list of files that have been added/changed ... 1 file
Fixing whitespace ... 0 files
Docs modified ... NO
Misc/ACKS updated ... NO
Misc/NEWS updated ... NO

Did you run the test suite?

status: closed -> open

Python tracker <report at bugs.python.org>

More information about the Python-bugs-list mailing list