[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT
report at bugs.python.org
Sun Jul 11 14:39:06 CEST 2010
Reid Kleckner <rnk at mit.edu> added the comment:
This patch looks good to me, after digging through the relevant module code.
I was confused though for a bit as to why PyModuleDef is a PyObject with a NULL type. It turns out that import.c wants to keep them in a dictionary, so it needs to be able to cast to PyObject* and to access the refcount. It never needs the type, though, so it's safe to leave it NULL. I think it might be worth adding comments explaining that in this patch or another.
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list