[issue9036] Simplify Py_CHARMASK

Stefan Krah report at bugs.python.org
Sat Jul 17 19:40:28 CEST 2010


Stefan Krah <stefan-usenet at bytereef.org> added the comment:

[Marc-Andre]
> Why not just make the casts in those cases explicit instead of
> using Py_CHARMASK ?

I agree that this would be the cleanest solution. It's harder to get
someone to review a larger patch though.


Antoine, I understood that you would prefer to leave the mask. Could I
apply the second version of the patch?

It will probably have an immediate benefit. On the ARM buildbot char
is unsigned and gcc emits a whole page of spurious 'array subscript has
type 'char' warnings.

----------
Added file: http://bugs.python.org/file18044/py_charmask2.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9036>
_______________________________________


More information about the Python-bugs-list mailing list