[issue1723038] Curses Menu

Amaury Forgeot d'Arc report at bugs.python.org
Thu Jul 22 11:55:21 CEST 2010


Amaury Forgeot d'Arc <amauryfa at gmail.com> added the comment:

The patch should be amended for python3, then:
- PyType_Ready() should be used instead of "ob_type = &PyType_Type;"
- The demo contains "Option choisie :" which should be translated :-)
- the call::
     PyErr_SetString(PyExc_RuntimeError,
                     "remove_lom: can't find Menu Object");
  is wrong: the calling function does not check the error condition, it will be ignored in any case because the only called is the tp_dealloc
- find_po() is defined but never called
- the free() method does not do anything, it contains commented out code.

In short, this patch needs work.

----------
nosy: +amaury.forgeotdarc
stage: unit test needed -> needs patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue1723038>
_______________________________________


More information about the Python-bugs-list mailing list