[issue9214] Most Set methods of KeysView and ItemsView do not work right

Eli Bendersky report at bugs.python.org
Mon Jul 26 06:27:49 CEST 2010

Eli Bendersky <eliben at gmail.com> added the comment:


I'm attaching a patch for this issue. 

1. _from_iterable in KeysView and ItemsView overridden as per Daniel's suggestion (Lib/_abcoll.py)
2. Added a test case to Lib/test/test_collections.py that uses this test case (creates the subclass and attempts modifying the view), with Raymond's suggestions incorporated, as well as a simple correctness test.

The patch was made against the latest dev checkout. If it's found sufficient, I can backport it to 2.6/2.7


P.S. The patch was generated from a Hg mirror, so to patch it -p1 is to be used. If this is a problem, let me know and I'll generate a patch from an SVN working directory. I got the impression from the #python-dev IRC channel that submitting patches from Hg is fine, but I may be wrong here.

keywords: +patch
Added file: http://bugs.python.org/file18208/issue9214.1.patch

Python tracker <report at bugs.python.org>

More information about the Python-bugs-list mailing list