[issue8852] _socket fails to build on OpenSolaris x64

[David Kirkby]

David Kirkby <david.kirkby at onetel.net> added the comment:

Thank you Mark for confirming what I found. 

I understand your reservations about the code if you don't know of its correctness. I must admit I don't myself. I don't have a clue how this _socket module should be built. 

But it is clear to me that the original code is attempting to compile code using PACKET_LOOPBACK, PACKET_FASTROUTE and SIOCGIFNAME, despite they are not defined. Although I'm not a mind-reader, I believer the original programmer probably thought they were defined in the header file netpacket/packet.h, when in fact they are not on Solaris. 

I wish I could take Martin v. Löwis up on his "5-for-one deal", where I review 5 issues and he deals with this one. Unfortunately, I'm very new to python, so really are not going to be a lot of help to anyone in reviewing issues. I will just have to keep that patch in Sage until it either gets to the top of Martin's TODO list, or someone else deals with it. 

Dave

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue8852>
_______________________________________