[issue7673] audioop: check that length is a multiple of the size

Mark Dickinson report at bugs.python.org
Tue Jun 29 21:02:09 CEST 2010

Mark Dickinson <dickinsm at gmail.com> added the comment:

The patch looks fine to me.

- Please could you add some tests, to exercise the 'not a whole number of frames' errors?

- The patch obviously predates the grand reindenting, so its indentation needs fixing up

PEP 7 nits:

 - Please don't put spaces just inside the parens in an 'if' statement:  i.e., use "if (size != 1 ...)", not "if ( size != 1 ...)"  (I notice that the "if ( x == NULL )" style is already prevalent, though not universal, in the module, though.)

 - the 'else' clause of an if should be at the start of the line (i.e.,
on a new line below the closing brace of the 'if', if present)

Is there any particular reason that Python 3.1 is not included in the versions?

nosy: +mark.dickinson

Python tracker <report at bugs.python.org>

More information about the Python-bugs-list mailing list