[issue3928] os.mknod missing on Solaris

[Roumen Petrov]

Roumen Petrov <bugtrack at roumenpetrov.info> added the comment:

Jesús Cea Avión wrote:
>
> Jesús Cea Avión<jcea at jcea.es>  added the comment:
>
> I just did the minimal change. I don't know if removing "defined(HAVE_MAKEDEV)" is safe.

The python build system is full with minimal changes and result is a big 
mess. Did you found which revision add ".. defined(HAVE_MAKEDEV)" in 
posix*.c ?

> "HAVE_DEVICE_MACROS" is defined if "configure" finds "makedev()" macro.

And what is result on you platform ?

> Clarify your comment about configure.in changes being wrong.

Usually just adding #include <xxxx> will break test on platforms where 
xxxx is missing.

The correct implementation will depend from above.

Cases:
1) platform is no longer supported - it is save to remove test case from 
configure and defined(HAVE_MAKEDEV) from posixmodule.c

2) HAVE_DEVICE_MACROS is defined for you . Then check how is written 
test for HAVE_DEVICE_MACROS and make test for makedev similar.

Roumen

----------
nosy: +rpetrov

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3928>
_______________________________________