[issue7594] shlex refactoring

Mark Hammond report at bugs.python.org
Thu May 6 02:56:38 CEST 2010


Mark Hammond <mhammond at users.sourceforge.net> added the comment:

I tried to use this in place of shlex for parsing IMAP responses for the 'imapclient' package.  A couple of things struck me.

* The class no longer has a next() method but probably should be added for b/w compat.

* The class no longer has a 'token' attribute, which people may use to record the current token.  Sadly it isn't clear if this is a documented part of the API or not.

* Typo:
    wordchards = property(_get_wordchars, _set_wordchars)

  'wordchards' is wrong.  This implies there are no tests which set wordchars.

* I *think* the lexer is now returning an empty string token as an input source is rolled over whereas before it did not.  In effect, I *think* the old lexer would allow a single token to span sources, where this patched version does not.  Sadly I didn't confirm this is truly accurate - but tests for this behaviour would probably help.

----------
nosy: +mhammond

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue7594>
_______________________________________


More information about the Python-bugs-list mailing list