[issue10242] unittest's assertItemsEqual() method makes too many assumptions about its input

Georg Brandl report at bugs.python.org
Mon Nov 29 09:51:26 CET 2010


Georg Brandl <georg at python.org> added the comment:

ISTM that the new name is worse than the old name.  I hadn't followed this issue, heard assertCountEqual the first time today, and couldn't guess what it does.  I'd have assumed that it checks only for equality of the number of items in a sequence, not for equality of the actual items.

I appreciate that it's hard finding good short names, but just because the implementation uses collections.Counter does not mean that Count needs to be in the method name :)

----------
nosy: +georg.brandl

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue10242>
_______________________________________


More information about the Python-bugs-list mailing list