[issue9894] wrong errno check

[Pino Toscano]

New submission from Pino Toscano <toscano.pino at tiscali.it>:

In Lib/test/test_subprocess.py there's a check of an errno value done against a number, instead of using the proper E* constants, which is not portable (POSIX does not specify any actual value of the E* constants).
This makes the test test_leaking_fds_on_error fail on OSes where the errno ENOENT has a value different than two (like on GNU/Hurd, for example).

The attached patch was done in the py3k branch, but the issue appears in any other branch (including trunk). Could you please fix the issue also in the active Python branches?

----------
components: Tests
files: errno_py3k.diff
keywords: patch
messages: 116813
nosy: pino
priority: normal
severity: normal
status: open
title: wrong errno check
type: behavior
versions: Python 3.2
Added file: http://bugs.python.org/file18920/errno_py3k.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9894>
_______________________________________