[issue11049] add tests for test.support
Eli Bendersky
report at bugs.python.org
Sat Jan 29 06:22:07 CET 2011
Eli Bendersky <eliben at gmail.com> added the comment:
Giampaolo,
The patch looks good. Some minor comments below:
* class TestCase(unittest.TestCase): -> why not give the test class a more useful name?
* import_fresh_module is tested similarly to import_module - can't a test be added that it indeed performs its "special sauce"?
* test_DirsOnSysPath: you may want to use assertIn and assertNotIn here. [these were added to Python in 3.1]
* test_python_is_optimized: you may want to use assertIsInstance here.
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11049>
_______________________________________
More information about the Python-bugs-list
mailing list