[issue12287] ossaudiodev: stack corruption with FD >= FD_SETSIZE
STINNER Victor
report at bugs.python.org
Fri Jun 10 23:57:27 CEST 2011
STINNER Victor <victor.stinner at haypocalc.com> added the comment:
Comments on is_selectable.diff.
> +#define IS_SELECTABLE(s) (_PyIsSelectable_fd((s)->sock_fd) || s->sock_timeout <= 0.0)
You may add parenthesis around the second s (even if it's unrelated to this issue and not a regression of your patch).
> +#ifdef Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE
> ...
> #if defined(_MSC_VER)
> max = 0; /* not used for Win32 */
I still don't understand these checks: why not testing simply for #ifdef MS_WINDOWS? MinGW or Cygwin have another implementation of select() which is more limited?
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12287>
_______________________________________
More information about the Python-bugs-list
mailing list