[issue11369] Add caching for the isEnabledFor() computation

Vinay Sajip report at bugs.python.org
Fri Mar 4 22:38:27 CET 2011


Vinay Sajip <vinay_sajip at yahoo.co.uk> added the comment:

> I had somewhat shallow logger hierarchies (3-4  deep).  The real problem was> 
>that this was being called in a kernel of  my code ... so even that

> additional cost was noteworthy.
> 
> I think it's  smart to focus on Python 3.3. As it happens, my colleagues did
> some explicit  caching of logging information that made pyutilib.logging
> redundant.   When you don't think you need this as a reference
> implementation, I'll delete  it.

You can go ahead and do that, since the diff attached to this ticket will give 
me any information I need. I already have a patch of a solution which caches the 
effective level, but I need some time to benchmark what the improvement is, and 
whether it is effective enough to warrant committing. Anyway it's for Python 
3.3, so we have time to get it right :-)

Thanks for your feedback.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11369>
_______________________________________


More information about the Python-bugs-list mailing list