[issue11072] Add MLSD command support to ftplib

Giampaolo Rodola' report at bugs.python.org
Thu Mar 10 00:21:13 CET 2011


Giampaolo Rodola' <g.rodola at gmail.com> added the comment:

You're right about r/strip(), thanks (new patch in attachment).

> In your test you're checking whether returned facts 
> contain every requested fact, this is not guaranteed by RFC.

Yes, but we're using a dummy FTP server returning static MLSD_DATA, so this is not important.

> Also, not sure what the last for statement 
> is supposed to mean. Is it a typo?

It makes sure whether in case of directory empty (see: no data returned) we don't enter in the "for" block.
Probably it's not even necessary because this is already tested by:
self.assertRaises(StopIteration, next, self.client.mlsd())
...but... whathever.

----------
Added file: http://bugs.python.org/file21066/ftplib_mlsd_v3.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11072>
_______________________________________


More information about the Python-bugs-list mailing list