[issue11570] Lib/test/test_distutils.py tries to mix 32 and 64 bits object files, doesn't obey LDFLAGS

[Jesús Cea Avión]

Jesús Cea Avión <jcea at jcea.es> added the comment:

This patch is hacky, but 3.1 is in maintenance mode.

This patch should be safe. It only touch SunOS compilation. It passes the testsuite, and it should allow 64 bit compilation of extension packages.

This patch is not needed in 3.2 and 3.x. It only affects 3.1.

The patch:

"""
diff -r f2ac5bbc1623 configure.in
--- a/configure.in      Wed Mar 16 12:48:54 2011 +0200
+++ b/configure.in      Wed Mar 16 14:10:53 2011 +0000
@@ -1758,8 +1758,8 @@
        IRIX*/6*) LDSHARED="ld ${SGI_ABI} -shared -all";;
        SunOS/5*) 
                if test "$GCC" = "yes"
-               then LDSHARED='$(CC) -shared'
-               else LDSHARED='$(CC) -G';
+               then LDSHARED='$(CC) -shared $(LDFLAGS)'
+               else LDSHARED='$(CC) -G $(LDFLAGS)';
                fi ;;
        hp*|HP*)
                if test "$GCC" = "yes"
"""

Please, review. If everything is OK, I will commit the patch myself.

----------
keywords: +needs review
stage: needs patch -> patch review

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11570>
_______________________________________